User "Nikerabbit" posted a comment on MediaWiki.r86775. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86775#c16283 Commit summary:
Stop stubbing $wgLang and $wgContLang. There are no major code paths which do not call either $wgLang or $wgContLang at least once. All index.php calls unstub $wgContLang from MediaWiki::parseTitle() except in the edgecase of viewing pages referenced only by "curid=123", and since those will end up calling OutputPage::output() they will eventually be unstubbed at some point as well. All calls through load.php unstub $wgLang in ResourceLoaderContext::getLanguage() from ResouceLoader::respond() --> ResourceLoader::preloadModuleInfo(). All calls through api.php unstub $wgContLang in ApiResult::cleanUpUTF8() from ApiMain::printResult(). Comment: <pre> [23-Apr-2011 21:20:09] PHP Warning: in_array() expects parameter 2 to be array, null given in /www/sandwiki/extensions/LanguageSelector/LanguageSelector.php on line 164 [23-Apr-2011 21:20:09] <ul> <li>LanguageSelector.php line 127 calls wfBacktrace()</li> <li>- line - calls wfLanguageSelectorGetLanguageCode()</li> <li>Hooks.php line 235 calls call_user_func_array()</li> <li>Hooks.php line 38 calls Hooks::run()</li> <li>RequestContext.php line 119 calls wfRunHooks()</li> <li>Setup.php line 411 calls RequestContext::getLang()</li> <li>WebStart.php line 169 calls require_once()</li> <li>load.php line 39 calls require()</li> </ul> [23-Apr-2011 21:20:09] PHP Warning: in_array() expects parameter 2 to be array, null given in /www/sandwiki/extensions/LanguageSelector/LanguageSelector.php on line 164 </pre> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
