User "Happy-melon" posted a comment on MediaWiki.r86775. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86775#c16360 Commit summary:
Stop stubbing $wgLang and $wgContLang. There are no major code paths which do not call either $wgLang or $wgContLang at least once. All index.php calls unstub $wgContLang from MediaWiki::parseTitle() except in the edgecase of viewing pages referenced only by "curid=123", and since those will end up calling OutputPage::output() they will eventually be unstubbed at some point as well. All calls through load.php unstub $wgLang in ResourceLoaderContext::getLanguage() from ResouceLoader::respond() --> ResourceLoader::preloadModuleInfo(). All calls through api.php unstub $wgContLang in ApiResult::cleanUpUTF8() from ApiMain::printResult(). Comment: This is nothing to do with $wgUseDatabaseMessages, it's because LocalisationCache doesn't respect that as meaning it shouldn't try and safe its cache data in the database. The PHPUnitMaintClass::finalSetup() call is made before Setup.php is included, so that global is already set, AFAICT anyway. The unit tests run fine on my setup, at least as far as the parser tests. Which test generates that error for you? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
