User "MarkAHershberger" posted a comment on MediaWiki.r86775.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86775#c16286
Commit summary:
Stop stubbing $wgLang and $wgContLang. There are no major code paths which do
not call either $wgLang or $wgContLang at least once. All index.php calls
unstub $wgContLang from MediaWiki::parseTitle() except in the edgecase of
viewing pages referenced only by "curid=123", and since those will end up
calling OutputPage::output() they will eventually be unstubbed at some point as
well. All calls through load.php unstub $wgLang in
ResourceLoaderContext::getLanguage() from ResouceLoader::respond() -->
ResourceLoader::preloadModuleInfo(). All calls through api.php unstub
$wgContLang in ApiResult::cleanUpUTF8() from ApiMain::printResult().
Comment:
Problem running install.php, starting with this revision:
<pre>
$ php maintenance/install.php --dbtype=sqlite --dbpath=/tmp --pass=testpass
test test
DB connection error: Access denied for user 'wikiuser'@'localhost' (using
password: NO) (localhost)
Backtrace:
#0
/home/ci/test-server/cc-home/projects/mw/source/includes/db/DatabaseMysql.php(131):
DatabaseBase->reportConnectionError(' Access denied ...')
#1
/home/ci/test-server/cc-home/projects/mw/source/includes/db/Database.php(518):
DatabaseMysql->open('localhost', 'wikiuser', '', 'my_wiki')
#2
/home/ci/test-server/cc-home/projects/mw/source/includes/db/Database.php(566):
DatabaseBase->__construct('localhost', 'wikiuser', '', 'my_wiki', 16, 'get
from global')
#3
/home/ci/test-server/cc-home/projects/mw/source/includes/db/LoadBalancer.php(658):
DatabaseBase::newFromType('mysql', Array)
#4
/home/ci/test-server/cc-home/projects/mw/source/includes/db/LoadBalancer.php(539):
LoadBalancer->reallyOpenConnection(Array, false)
#5
/home/ci/test-server/cc-home/projects/mw/source/includes/db/LoadBalancer.php(460):
LoadBalancer->openConnection(0, false)
#6
/home/ci/test-server/cc-home/projects/mw/source/includes/GlobalFunctions.php(3117):
LoadBalancer->getConnection(-1, Array, false)
#7
/home/ci/test-server/cc-home/projects/mw/source/includes/LocalisationCache.php(768):
wfGetDB(-1)
#8
/home/ci/test-server/cc-home/projects/mw/source/includes/LocalisationCache.php(318):
LCStore_DB->get('en', 'deps')
#9
/home/ci/test-server/cc-home/projects/mw/source/includes/LocalisationCache.php(353):
LocalisationCache->isExpired('en')
#10
/home/ci/test-server/cc-home/projects/mw/source/includes/LocalisationCache.php(259):
LocalisationCache->initLanguage('en')
#11
/home/ci/test-server/cc-home/projects/mw/source/includes/LocalisationCache.php(205):
LocalisationCache->loadItem('en', 'defaultUserOpti...')
#12
/home/ci/test-server/cc-home/projects/mw/source/languages/Language.php(529):
LocalisationCache->getItem('en', 'defaultUserOpti...')
#13 /home/ci/test-server/cc-home/projects/mw/source/includes/User.php(1052):
Language->getDefaultUserOptionOverrides()
#14 /home/ci/test-server/cc-home/projects/mw/source/includes/User.php(1944):
User::getDefaultOptions()
#15
/home/ci/test-server/cc-home/projects/mw/source/includes/RequestContext.php(108):
User->getOption('language')
#16 /home/ci/test-server/cc-home/projects/mw/source/includes/Setup.php(411):
RequestContext->getLang()
#17
/home/ci/test-server/cc-home/projects/mw/source/maintenance/doMaintenance.php(108):
require_once('/home/ci/test-s...')
#18
/home/ci/test-server/cc-home/projects/mw/source/maintenance/install.php(94):
require_once('/home/ci/test-s...')
#19 {main}
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
