User "Nikerabbit" posted a comment on MediaWiki.r92559.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92559#c19832
Commit summary:
Major update of stable features from development code.
* For non-existing info pages (Wx/xx[x] pages), add a welcome page (either
missing, existing or closed wikis)
* It automatically checks the database list if available (which is the case on
WMF wikis), like SiteMatrix
* Pages belonging to existing wikis are not editable and show a link to the
existing wiki. You will be redirected automatically if URL &testwiki or your
preference is set to that test wiki.
* Show a logo per-project, and possibility to set it per-wiki (if URL &testwiki
or your preference is set to that test wiki)
This is developed against 1.17wmf1 so everything should work on Incubator
itself.
Comment:
Is this register_globals vulnerability?
<pre>
+$wmincClosedWikis = isset( $wgSiteMatrixClosedSites ) ?
$wgSiteMatrixClosedSites : null;
</pre>
That variable is always defined, why would it be undefined?
<pre>
+ } elseif( !isset( $wmincExistingWikis ) || !is_array(
$wmincExistingWikis ) ) {
</pre>
</pre>
$wgUser->getSkin()->
</pre>
You can use the trick Dantman showed me. You can get rid of one global.
<pre>
$linker = class_exists( 'DummyLinker' ) ? new DummyLinker : new Linker;
</pre>
Could you document getSubdomain?
$params can be an array, no need to build it by appending to a string.
</pre>
+$url = $mainpage->getFullURL( $params );
</pre>
''return'' as in return from the function or return some value (what?).
+# return if MediaWiki: Incubator-logo-wx/xx(x) does not exists
Please use !$file or $file === null, depending on which is appropriate.
+ if ( $file == null ) {
What is this rule for?
<pre>
+#ca-nstab-main a {
+ color: black;
+}
</pre>
In InfoPage.php there are some NULLs (should be lowercase) and missing
whitespace. Could you also document the infopage messages (if not done
already), thanks.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
