User "SPQRobin" posted a comment on MediaWiki.r92559.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92559#c20787
Commit summary:

Major update of stable features from development code.
* For non-existing info pages (Wx/xx[x] pages), add a welcome page (either 
missing, existing or closed wikis)
* It automatically checks the database list if available (which is the case on 
WMF wikis), like SiteMatrix
* Pages belonging to existing wikis are not editable and show a link to the 
existing wiki. You will be redirected automatically if URL &testwiki or your 
preference is set to that test wiki.
* Show a logo per-project, and possibility to set it per-wiki (if URL &testwiki 
or your preference is set to that test wiki)
This is developed against 1.17wmf1 so everything should work on Incubator 
itself.

Comment:

Things like preg_replace() -> str_replace() were already done in one of my 
recent commits. The rest should all have been addressed in r94482:
As for the rawElement, that was not possible because the "a" tags would then be 
escaped, thus not forming the URL. Instead, I used wfMsgWikiHtml().
As for the $created and $bug, that's something intended for future use. Maybe 
should've left that out :)
And for the addModuleStyles(): awesome! it's much better without the flash of 
unstyled content :-)

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to