User "Catrope" posted a comment on MediaWiki.r92559.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92559#c20748
Commit summary:
Major update of stable features from development code.
* For non-existing info pages (Wx/xx[x] pages), add a welcome page (either
missing, existing or closed wikis)
* It automatically checks the database list if available (which is the case on
WMF wikis), like SiteMatrix
* Pages belonging to existing wikis are not editable and show a link to the
existing wiki. You will be redirected automatically if URL &testwiki or your
preference is set to that test wiki.
* Show a logo per-project, and possibility to set it per-wiki (if URL &testwiki
or your preference is set to that test wiki)
This is developed against 1.17wmf1 so everything should work on Incubator
itself.
Comment:
Not introduced in this rev, but:
<pre>
$listProjects = implode( '', array_keys( $wmincProjects ) ); #
something like: pbtqn
if( !preg_match( '/^W['.$listProjects.']\/[a-z-]+' .
</pre>
This is a very dirty hack which assumes that <code>$wmincProjects</code> will
always be an array of single-character strings that have no special meaning in
regexes. A proper implementation would use <code>implode( '|' , ... )</code>
and would <code>preg_quote()</code> the elements before using them.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
