User "Jack Phoenix" posted a comment on MediaWiki.r81507. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81507#c20527 Commit summary:
Completely remove support for legacy style skins. All legacy skinning options are now part of a SkinLegacy/LegacySkinTemplate pair that inherits from the normal SkinTemplate setup. Also ported our three built in skins to use the new legacy classes. ( ;) if you want to kill legacy skins now, you only have to svn rm 4 files) Comment: I don't like this. Sure, I'm all for moving Cologne Blue & friends out of core, whether it be to an extension or just killing them off entirely. However, I don't think this is the direction we should be taking. SkinTemplate is, to put it nicely, a big fucking mess. We shouldn't be encouraging people to move to it, we should be encouraging them to move '''off''' from it. The way I see it, Skin should be the base class for '''all''' skins, like how I tried with my [[Special:Code/MediaWiki/62306|SkinSystemRewrite project]]. Admittedly my approach wasn't the prettiest one, but you can see the general idea. With SkinTemplate, nothing is really standardized; you have to do [[Extension:ShoutWiki Ads#Patch|all kinds of hacks]] for the simplest things and there's very little consistency to speak of, if any. Your statement ''I'm quite certain that we don't have a single 3rd party skin that is not SkinTemplate based'' is false; there are custom skins that extend Skin instead of SkinTemplate, such as the skin used by Halopedia (http://www.halopedian.com/ — can't make it a normal external link because CR's parser sucks), the Sports skin used by ArmchairGM, the Games skin used by gaming.wikia back in 2007...it's quite annoying to have to adjust skins for every MW release. One-line patches, two-line patches, even 30-line patches are OK and I've done those. Asking me to rewrite four skins that work well in 1.16 for 1.19 doesn't seem very fair to me. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
