User "Jack Phoenix" posted a comment on MediaWiki.r81507. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81507#c20647 Commit summary:
Completely remove support for legacy style skins. All legacy skinning options are now part of a SkinLegacy/LegacySkinTemplate pair that inherits from the normal SkinTemplate setup. Also ported our three built in skins to use the new legacy classes. ( ;) if you want to kill legacy skins now, you only have to svn rm 4 files) Comment: Fair enough. Needless to say, any and all improvements to the skin system are welcome — but in the future, please do retain backwards compatibility for a few releases. As for the ArmchairGM and Games skin, they're currently not used by any site out there, but I for one had plans to use the skins. After all, the ArmchairGM codebase was open sourced less than two weeks ago (see http://ashleywiki.blogspot.com/2011/08/armchairgm-is-finally-open-source.html ); ever since I've been working on those two skins, improving them and bringing them up to modern standards. Still, there's plenty of things to do and that's why I haven't committed my work; I don't like committing half-baked code. I definitely plan to commit and use those skins, though; they were nearly lost and it'd have been a great shame had they been lost for good. The fourth Skin-based skin is what I call ''Magazine''; a skin based on the various different skins written for Wikia's magazine wikis back in 2007 or so. Originally each magazine wiki had their own skin; the only distinction (besides the skin name, of course) between the skins was the CSS. I cleaned up one of these skin files and made it support themes. Sure, it's quite ugly right now, but in the right hands, someone could turn it into a pretty decent skin, I think. One of these days I should clean up the code and release it; before that, I probably should fix the usage of $wgMessageCache and other equally ugly things in the code. (Do we have a better place for custom skins than trunk/extensions/skins/? It seems less than ideal to me since the folder contains many skins and most core skins are in $IP/skins/...) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
