User "Dantman" posted a comment on MediaWiki.r81507. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/81507#c20584 Commit summary:
Completely remove support for legacy style skins. All legacy skinning options are now part of a SkinLegacy/LegacySkinTemplate pair that inherits from the normal SkinTemplate setup. Also ported our three built in skins to use the new legacy classes. ( ;) if you want to kill legacy skins now, you only have to svn rm 4 files) Comment: On the state of SkinTemplate, I don't see how that 'flaw' in SkinTemplate is relevant to the legacy skin system. The patch you end up needing to apply there isn't even applicable because if MonoBook was implemented using the old skin system you still wouldn't be able to put something in that spot, you'd still need to apply the same kind of patch. I do agree that the detached SkinTemplate+QuickTemplate methodology and pattern of pre-assigning keys in ways that make some skinning possibilities prohibitive is flawed. But the original Skin system is not the answer to that, the original Skin system is exponentially worse. Only allowing before/after input instead of proper full control over the body of the skin to the skin author, aging methods incompatible with standard features... I do have plans for a skin system that doesn't have the flaws of SkinTemplate. It's also possible to replace SkinTemplate with a layer meant for complete compatibility on top of that layer (ie: That better skin system can be put into place while remaining completely compatible with all SkinTemplate systems, and without creating a fork in implementations that causes SkinTemplate skins to start stagnating like legacy skins did and getting in the way of the implementation of new features). The legacy skin system however, is just in the way. The way it works doesn't make building a compat layer on top of either SkinTemplate or the new system a possibility without requiring modifications to skins using it. Does anyone even use the ArmchairGM skin or Games skin anymore? I can't even find the source for those, much less someone using them. Halopedian, I suppose it will need to be fixed for 1.19; I could take a look at what it would take to fix. Though frankly it looks so much more like a SkinTemplate skin than a LegacySkin that it doesn't look like it would be anywhere near the trouble to port that fixing something like CologneBlue would be. And fourth skin? What skin? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
