User "Bawolff" posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22282 Commit summary:
Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests. Comment: Personally I find it slightly weird to have a function that switches the width and height if rotating, only to switch it right back when we actually do the rotation. Although I guess having ''physicalWidth'' mean the width before rotating, and ''width'' be post-rotation width would be even worse. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
