User "Brion VIBBER" posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22285 Commit summary:
Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests. Comment: The thing to remember is that conceptually, the "real" size/orientation of the image is what you get '''after''' applying the EXIF orientation rotations or flips on the raw file -- from a user's perspective, you simply have (say) a portrait image, not a rotated landscape image. So the only time we actually want to be dealing with raw pre-rotation width/height is when we need to pass that & the rotation information to something that does low-level image manipulation, because that's what it needs access to in order to produce correct output. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
