User "Brion VIBBER" posted a comment on MediaWiki.r92246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92246#c22871 Commit summary:
Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests. Comment: Test changes look wrong -- for some reason it's comparing $file->getWidth() and $file->getHeight() against "pre-rotation dimensions" -- it should compare them against logical dimensions (eg, post-rotation). So for the portrait image we should see 768x1024. I've restored the testMetadata test to its original form, checking the returned getWidth/getHeight against the expected logical values, in r97651 -- which it clearly fails. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
