User "Brion VIBBER" changed the status of MediaWiki.r99911.

Old Status: new
New Status: fixme

User "Brion VIBBER" also posted a comment on MediaWiki.r99911.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99911#c24328
Commit summary:

Per bug 28135, disable $wgMaxImageArea check when transforming using a hook, 
and enable the check for non IM scalers.

Comment:

phpunit test failures:

<pre>
$ php phpunit.php includes/media/BitmapScalingTest.php 
PHPUnit 3.5.15 by Sebastian Bergmann.

.......FF

Time: 0 seconds, Memory: 14.75Mb

There were 2 failures:

1) BitmapScalingTest::testTooBigImage
Failed asserting that <boolean:true> is false.

/Library/WebServer/Documents/trunk/tests/phpunit/includes/media/BitmapScalingTest.php:108
/Library/WebServer/Documents/trunk/tests/phpunit/MediaWikiTestCase.php:64
/Library/WebServer/Documents/trunk/tests/phpunit/MediaWikiPHPUnitCommand.php:31
/Library/WebServer/Documents/trunk/tests/phpunit/phpunit.php:60

2) BitmapScalingTest::testTooBigMustRenderImage
Failed asserting that <boolean:true> is false.

/Library/WebServer/Documents/trunk/tests/phpunit/includes/media/BitmapScalingTest.php:115
/Library/WebServer/Documents/trunk/tests/phpunit/MediaWikiTestCase.php:64
/Library/WebServer/Documents/trunk/tests/phpunit/MediaWikiPHPUnitCommand.php:31
/Library/WebServer/Documents/trunk/tests/phpunit/phpunit.php:60

FAILURES!
Tests: 9, Assertions: 16, Failures: 2.
</pre>


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to