User "Happy-melon" posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c24606 Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: I don't think it will do any ''harm'' in 1.17wmf1, but it shouldn't be ''necessary''. The patches both solve the immediate problem by ensuring that the steward's IP address is not saved into <tt>ipb_by_text</tt>. Once that is in place (and the DB is swept for existing instances) the output hack can be removed. There isn't anything wrong per se with the core code; it just doesn't play nicely with the CentralAuth code. There is no fundamental reason why anonymous users can't be given the block permission, in which case we ''would'' want to display their IPs. What's needed is to ensure that CentralAuth is sending User objects with the correct data to $block->setBlocker(); currently that can be achieved by a hack (patches); there is scope for a nicer implementation. I could write that implementation if you'd like, but without a CentralAuth test environment for me to test it on it wouldn't be very productive. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
