User "Brion VIBBER" posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c24337 Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: Looks like it ought to work in theory, but it's a hack on a hack on a hack on a hack on a hack on a hack. The entire local suppression thingy seems to be abusing Block::insert's database parameter to insert blocks directly into a foreign database, which should generally not be done -- I don't _think_ there's any active corruption from it but it looks very scary. Would probably recommend applying the live hack to trunk -- as it's been tested in production -- rather than increasing the amount of code without a solid refactor. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
