User "Happy-melon" posted a comment on MediaWiki.r84534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c24595 Commit summary:
(hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. Comment: It's introduced in the blocking rewrite, so only 1.18wmf1. Basically: *CentralAuth is saving blocks into the foreign wikis' databases *In the new code Block takes a User object or userid rather than id/name separately *The User CentralAuth creates is given id 0 because the steward might not have an account on the foreign wiki *When Block->update() is called, it gets the user name and id from the User; because the userid is 0, the 'name' is the current IP address What ultimately needs to happen is we need to be able to send $block->setBlocker() a ForeignUser subclassing User, which returns the steward's name from getName() but still returns getId() of 0 (or even better, returns the steward's actual ID if they ''do'' have a local account). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
