User "Catrope" posted a comment on MediaWiki.r100905.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100905#c24918
Commit summary:
Adding context to the API
This will probably break something somewhere so when it does please yell at me
on IRC and I'll fix it.
Comment:
<pre>
+ } elseif ( $context instanceof WebRequest ) {
+ // BC for pre-1.19
+ $request = $context;
+ $context = RequestContext::getMain();
+ $context->setRequest( $request );
+ }
</pre>
This essentially sets the global context's request ("wgRequest") to whatever
was passed into this constructor. That doesn't sound like a good idea. It
should probably be done after creating the DerivativeContext instead.
There is some commented code and commenting out of code in your commit, please
clean that up.
The architecture here (i.e. the changes to ApiMain and ApiBase) looks good to
me otherwise. There's probably some oversight somewhere in the bazillion other
changes, but I don't anticipate any fundamental problems.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
