User "MaxSem" posted a comment on MediaWiki.r100905.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100905#c25122
Commit summary:
Adding context to the API
This will probably break something somewhere so when it does please yell at me
on IRC and I'll fix it.
Comment:
Got it! The porblem was not in special pages, it was in
<pre>
} elseif ( $context instanceof WebRequest ) {
// BC for pre-1.19
$request = $context;
$context = RequestContext::getMain();
}
</pre>
So if someone tries to create an ApiMain object for internal use, and pass it
an instance of FauxRequest, old-style, they pollute global context with a
request that will blow everything out of the sky later. That's wrong.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
