User "Catrope" posted a comment on MediaWiki.r100905. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100905#c25988 Commit summary:
Adding context to the API This will probably break something somewhere so when it does please yell at me on IRC and I'll fix it. Comment: <pre> + // TODO: Does this still need $wgTitle? </pre> I believe so. I don't think wfMsg() and friends have been fixed to no longer depend on $wgTitle yet, have they? <pre> - $token = $wgUser->editToken( '', $this->getMain()->getRequest() ); + $token = $user->editToken( '', $this->getMain()->getRequest() ); </pre> Shouldn't this call <code>$this->getRequest()</code> directly? <pre> - $vals['preferencestoken'] = $wgUser->editToken( '', $this->getMain()->getRequest() ); + $vals['preferencestoken'] = $user->editToken( '', $this->getMain()->getRequest() ); </pre> Same OK otherwise. These comments are minor things, setting to OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
