On Thu, Dec 22, 2011 at 1:33 PM, Erwin Dokter <[email protected]> wrote: > It all started with revision 105280 > (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/105280), where > Hashdar commited a new color scheme for diffs based on the French scheme. > When this generated some flack for making "green the remove-color", I > submitted a patch that reversed the colors > (https://bugzilla.wikimedia.org/show_bug.cgi?id=33139). This was met with > general approval. >
General approval where? I'm not seeing it on the bug, or linked to from the bug. > Before it could be applied though, Brandon steps in with another patch > (https://www.mediawiki.org/wiki/Special:Code/MediaWiki/106884) that mixed > the old yellow with the new blue, that looks absolutely horrible; a view in > which I am not alone. I immediately submitted a new patch that adjusted the > colors and levels, which is now under discussion. > I don't think it looks absolutely horrible. And I don't see much agreement with that sentiment on the bug either. > However, today Hashdar closed my bug/patch as Resolved, as he considers the > matter closed. As the matter is clearly not, I reopened it. Now I would like > to invite as many devs as possible to chime in at r106884 (3rd link) to > evaluate the various options. Because if the current revision stands, and > subsequently makes in into MediaWiki, we will have a default diff color > scheme that will generate a guaranteed backlash form any project that uses > MediaWiki. > You're catastrophizing, I highly doubt we'll get guaranteed backlash over such a minor shift in diff colors. As they say on enwiki, [citation needed]. Also I believe you misunderstand the development process. It is iterative, in that we keep making improvements as we find them. Just because a revision is committed does not mean it will be the end result and further discussion is moot. > I'm not one to complain fast, but I now understand why develpers without > commit access just turn around and walk away; if submittd patches that have > approval are summarily overruled by those with commit access, there is > really no point in continueing to submit patches. > It is true that developers with commit access do have the technical ability to overrule submitted patches; we still operate within consensus. Whatever the development community decides is best for MediaWiki as a whole--not just enwiki, or even just WMF wikis--is what goes into the default release. As I commented on the revision (and I'm reiterating here), I think the diff colors as they currently stand in trunk are generally ok, maybe just need a minor tweak in the blues. -Chad _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
