"Krinkle" posted a comment on MediaWiki.r110276. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110276#c30241
Commit summary for MediaWiki.r110276: drop default parameters from r110252 Html::nmaespaceSelector() generate a select using 'namespace' value for both 'id' and 'name'. Hence passing: array( 'name' => 'namespace', 'id' => 'namespace' ) is not needed. Krinkle's comment: Please don't remove the 'name' from the callee. I specifically added that because SpecialRecentChanges and SpecialAllpages both use the query param "namespace" in their classes to retrieve the value, so the submission point should name this name. Not assume that Html::namespaceSelector will use the same name. Also aside from the query param reading for the name "namespace". There is also css/javascript specific for this special page that targets the id "namespace", again, those are pairs that belong together. This code should not assume anything about Html::namespaceSelector, it also makes debugging much easier and code more readable if for example SpecialRecentchanges::getDefaultOptions for output and the form generation for input both use the same name in their code. I'd prefer to revert this. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
