"Krinkle" posted a comment on MediaWiki.r110276. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110276#c30312
Commit summary for MediaWiki.r110276: drop default parameters from r110252 Html::nmaespaceSelector() generate a select using 'namespace' value for both 'id' and 'name'. Hence passing: array( 'name' => 'namespace', 'id' => 'namespace' ) is not needed. Krinkle's comment: :3. Or we could keep the default in <code> Html::namespaceSelector</code> for backwards compatibility and recommend that callers pass this :4. Or we could remove the defaults entirely and require that callers pass this. I think 4 is the best option here, which is save since this method was added just last week. No compatibility issues. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
