"Hashar" posted a comment on MediaWiki.r110276. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110276#c30307
Commit summary for MediaWiki.r110276: drop default parameters from r110252 Html::nmaespaceSelector() generate a select using 'namespace' value for both 'id' and 'name'. Hence passing: array( 'name' => 'namespace', 'id' => 'namespace' ) is not needed. Hashar's comment: As a summary, you seem to be afraid that someone change the 'namespace' default in Html::namespaceSelector(). So either we could: # change the default name/id to something else such as wpNamespace and reinstate the array( 'name' => 'namespace', 'id' => 'namespace' ) above # add a comment in Html::namespaceSelector() to keep the 'namespace' default since it is expected by various code paths / javascripts ... _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
