"Khorn (WMF)" posted a comment on Wikimedia.r1212. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c30640
Commit summary for Wikimedia.r1212: Adding module for Global Collect recurring payments. Khorn (WMF)'s comment: And, there's more (and I've been looking at code that is currently at the head revision): <ul> <li>I'm not seeing any code that sends donors another thank you email on a successful transaction. We need to be doing that.</li> <li>It looks like, with these queries, you're going to run a do_payment on all the recurring transactions, and not just the ones that came through globalcollect.</li> <li>You have a 'GLOBALCOLLECT' drush error case, but there's no 'GLOBALCOLLECT' in your error severity array. That means, whether or not you throw one, it will be ignored by the control loop.</li> <li>The dates could very easily get messy. We don't want to try to recur all the transactions that have a 'next' date of less than now, right now. If we did that right now on our current data set, the vast majority of transactions would recur on the 8th of every month. We need to maintain the day of the month that the donor started a recurring payment. And to that end, consider somebody who donates on, say, the 31st of any month, Everybody who donates on the 29th, 30th, or 31st should not be perma-moved to the 28th in three out of four Februaries</li> </ul> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
