"Khorn (WMF)" posted a comment on Wikimedia.r1212. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c31146
Commit summary for Wikimedia.r1212: Adding module for Global Collect recurring payments. Khorn (WMF)'s comment: This is partially a style consideration, but I feel it's worth arguing as it's currently against general policy to deploy unnecessary code. <br> In the .module file, in the function civicrm_recurring_globalcollect_build_url, you directly reference test resources from the main module. <br>None of the code we plan to deploy should depend on any piece of code that only exists for testing purposes. In fact, you should probably go ahead and assume that anything in a "tests" directory will be intentionally left off all code that will eventually make it to a prod server. <br>I realize that in this case, you'd have to explicitly pass in a URL parameter... which makes it not a blocking issue. However, it would make the production version less than water-tight, and should be cleaned up in the future. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
