"Khorn (WMF)" posted a comment on Wikimedia.r1212.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c30662

Commit summary for Wikimedia.r1212:

Adding module for Global Collect recurring payments.

Khorn (WMF)'s comment:

I have some suggestions here: 
Instead of using NOW for your time comparison, you could use the first second 
that qualifies as tomorrow. Then you don't skip transactions that happened 
later in the last day, than you happen to be running the query today. 

I also suspect that you don't actually need to include the cycle day as a 
selector in your query. You will need to pull it back, though, to determine if 
you should actually run the transaction today, or just update the date and time 
of your next attempt. That should keep the processing time down on subsequent 
runs. 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to