"Pgehres (WMF)" posted a comment on Wikimedia.r1329.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329#c30647

Commit summary for Wikimedia.r1329:

Putting in a hard coded fix for issue with selecting only one payment gateway 
for processing recurring payments in r1212. The lookup now joins the table 
`civicrm_payment_processor`.

Pgehres (WMF)'s comment:

We actually don't use civicrm_payment_processor or 
civicrm_payment_processor.payment_processor_type. Without modifying a bunch of 
other code, I would instead use:

<code>AND `civicrm_contribution_recur`.`trxn_id` LIKE 'GLOBALCOLLECT 
RECURRING%'</code>

which actually makes me wonder how things are getting into the 
civicrm_contribution_recur table in the first place.  That should probably 
happen somewhere in queue2civicrm when the initial transaction is processed.

P.S.  I checked and there is indeed an index on the trxn_id field in 
civicrm_contribution_recur.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to