"Jpostlethwaite" posted a comment on Wikimedia.r1329.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329#c31511

Commit summary for Wikimedia.r1329:

Putting in a hard coded fix for issue with selecting only one payment gateway 
for processing recurring payments in r1212. The lookup now joins the table 
`civicrm_payment_processor`.

Jpostlethwaite's comment:

I can do this, but it is a hack.

The way I have it set up is the correct way [ unless I made some errors :p ] 
for the current version of CiviCRM.

I agree this is easier:

<pre>
AND `civicrm_contribution_recur`.`trxn_id` LIKE 'GLOBALCOLLECT RECURRING%'
</pre>

What is wrong with how it is implemented now?

I thought our goal was to make this available to the CiviCRM community.

Removing this code would be  as step away from that direction. 



_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to