"Khorn (WMF)" changed the status of Wikimedia.r1346 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1346#c31157
Old Status: new New Status: fixme Commit summary for Wikimedia.r1346: Added $effort_id as a parameter to _queue2civicrm_contribution_insert(). See r1212. Khorn (WMF)'s comment: This is me being really picky, but... <br> ...empty() is totally slow. Here, is_null() would do exactly what you want, be way more performant, and more precise for what we're up to anyway. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
