"Jpostlethwaite" changed the status of Wikimedia.r1346 to "new" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1346#c31510
Old Status: fixme
New Status: new
Commit summary for Wikimedia.r1346:
Added $effort_id as a parameter to _queue2civicrm_contribution_insert(). See
r1212.
Jpostlethwaite's comment:
If I did is_null(), you could potentially get zeros in the $effort_id:
<pre>
// $effort_id = 0;
if ( !empty($effort_id)) {
$trxn_id .= ' - ' . (integer) $effort_id;
}
// $trxn_id = 'GLOBALCOLLECT RECURRING-0'
</pre>
This would potentially cause bad data if there were some other error that
caused $effort_id to be zero or an empty string as opposed to null.
I could put a line into sanitize $effort_id, but would be even heavier to run.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
