"Awjrichards" changed the status of Wikimedia.r1346 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1346#c31579
Old Status: new New Status: ok Commit summary for Wikimedia.r1346: Added $effort_id as a parameter to _queue2civicrm_contribution_insert(). See r1212. Awjrichards's comment: If it's actually not acceptable for $effort_id to be 0, then this is fine, I suppose, unless empty() is legitimately causing a performance problem. That said, if $effort_id IS set and IS supposed to evaluate to some integer, then that should probably be handled more explicitly. It seems using empty() in this case is kind of like using a sledgehammer for something that could be done with a scalpel. Yeah, mixed metaphor, I know but you get the idea. But seeing as how this should work as-is and really isn't that big of a deal, I'm marking as OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
