"Awjrichards" posted a comment on Wikimedia.r1212.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c31583

Commit summary for Wikimedia.r1212:

Adding module for Global Collect recurring payments.

Awjrichards's comment:

The query construction that happens in 
_civicrm_recurring_globalcollect_update_record() is a little difficult to 
follow, debug, test, or even review. You should break up the query construction 
in some way to make things clearer - probably the easiest way would be to make 
functions to handle the different types of queries that you're constructing and 
invoke them from within _civicrm_recurring_globalcollect_update_record().

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to