Francois Gouget wrote:
> 
>         Hi,
> 
>     Here's the first batch of missing prototypes I added based on the
> indications given by winapi_check.


> Here's the ChangeLog:
> 
>  * dlls/msvideo/msvfw32.spec
>    MCIWndCreate conflicts with the corresponding A/W macro
> 
>  * dlls/msvideo/msvideo_main.c
>    Replaced HANDLE types with the real type: HDRAWDIB
>    MCIWndCreate conflicts with the corresponding A/W macro
>
>  * include/vfw.h
>    Added some missing prototypes
>    Define the HDRAWDIB handle type
> 

Can I ask you to please skip these buts? They clash with my msvideo
patches (3 weeks to the end of exams!) Also, is there a reason that you
typedef'd HDRAWDIB in vfw.h, rather than using the macro in windef.h? I
just copied everyone else, so I'm quite sure I've missed something
somewhere. Some of the HANDLE types are typedef'd in windef.h.

The one change I didn't have was the MCIWndCreate change (I haven't
touched that code at all). I can see why that's needed, but how will
someone #include <vfw.h>, and use the MCIWndCreate function, if it's
#defined as a winelib type? I don't actually know what that function
does though, so this may be a nonissue. What is it called in the windows
dll? What do the windows header files do? (quikview crashes under wine)

I've also fixed most of the winapi_check stuff, and updated the vfw api
files for winapi_check.

Thanks,


Bradley

Reply via email to