On Sat, 3 Jun 2000, Bradley Baetz wrote:
> Francois Gouget wrote:
[... msvideo patches...]
> Can I ask you to please skip these buts? They clash with my msvideo
> patches (3 weeks to the end of exams!)
Sure. I think Alexandre has not yet applied them as I am supposed to
revise them.
> Also, is there a reason that you
> typedef'd HDRAWDIB in vfw.h, rather than using the macro in windef.h? I
> just copied everyone else, so I'm quite sure I've missed something
> somewhere. Some of the HANDLE types are typedef'd in windef.h.
Yes, most of the HANDLE declarations are done in windef.h but I
don't really understand why. Since HDRAWDIB is a type specific to vfw it
seems to make sense to declare it there.
One reason I can see why things are the way they are is that
DECLARE_HANDLE used to be undef'ed in windef which it turns out is
incompatible with the windows headers (I found a program that was using
the macro). I changed that but did not dare move all the handle type
declarations around.
Also I did not use DECLARE_HANDLE for HDRAWDIB, which matches the
way windows does it, but is bad IMO. I think next time around I would
use the macro anyway.
> The one change I didn't have was the MCIWndCreate change (I haven't
> touched that code at all). I can see why that's needed, but how will
> someone #include <vfw.h>, and use the MCIWndCreate function, if it's
> #defined as a winelib type?
I guess they don't. When I say that the DLL had three APIs I checked
with windows and saw that they do use the usual macro for MCIWndCreate.
So I assume that they create MCIWndCreate first and then realized that
it should really have an A and a W version, added those but did not
remove the original one to not cause compatibility problems. So I
assume one is not supposed to use the old one anymore.
Of course if one really wants to use the old one all one has to do
is to use GetProcAddress.
--
Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/
Good judgment comes from experience, and experience comes from bad judgment
-- Barry LePatner
