Hi Everyone,

I've been having a some trouble with applying some of the patches uploaded to 
JIRA.

I'd like to suggest and discuss a few guidelines for patches to hopefully make 
our lives a little bit easier. BTW, I'm using SVN and Eclipse so I'm biased 
towards that as being the lowest common denominator :-)

- The name of the patch should be WINK-XXX.patch, or WINK-XXX.updateX.patch for 
updates of patches 

- The root of the patch should be trunk (or the branch when it will applicable) 
whenever possible. If necessary, the root should be under the trunk (or branch) 
but avoid creating the patch from the parent of trunk.

- Avoid using GIT for patches. I'm not sure what it means, but there was this 
one patch I saw that had GIT in it, I think it was WINK-28 and I couldn't get 
it to work. I even tried to manually edit the file but still couldn't get it to 
work.

What do you think?

-Nadav


Reply via email to