Nadav, Hadn't seen much discussion on this, but it does look like the patches that are coming in comply with the pattern.
You could also include a "How to open a bug report" section on the wiki and place a link next to the JIRA resource link. -Nick Nicholas Gallardo WebSphere - REST & WebServices Development [email protected] Phone: 512-286-6258 Building: 903 / 5G-016 Michael Elman <[email protected] > To [email protected] 07/14/2009 06:15 cc AM Subject Re: Discussion: Guidelines for Please respond to patches in JIRA wink-...@incubato r.apache.org I think you can put it to under the Coding Guidelines in the wiki. On Sun, Jul 12, 2009 at 3:52 PM, Fischer, Nadav <[email protected]>wrote: > Hi Everyone, > > I've been having a some trouble with applying some of the patches uploaded > to JIRA. > > I'd like to suggest and discuss a few guidelines for patches to hopefully > make our lives a little bit easier. BTW, I'm using SVN and Eclipse so I'm > biased towards that as being the lowest common denominator :-) > > - The name of the patch should be WINK-XXX.patch, or WINK-XXX.updateX.patch > for updates of patches > > - The root of the patch should be trunk (or the branch when it will > applicable) whenever possible. If necessary, the root should be under the > trunk (or branch) but avoid creating the patch from the parent of trunk. > > - Avoid using GIT for patches. I'm not sure what it means, but there was > this one patch I saw that had GIT in it, I think it was WINK-28 and I > couldn't get it to work. I even tried to manually edit the file but still > couldn't get it to work. > > What do you think? > > -Nadav > > >
