I'll follow the guidelines as much as possible. I think these are good. The only exception I have is for the Git issue. As long as it can be applied with "standard" Unix tools like patch, I don't really see a problem too much there. It will just sit longer since not everyone has that command available to them all the time.
On Sun, Jul 12, 2009 at 7:52 AM, Fischer, Nadav<[email protected]> wrote: > Hi Everyone, > > I've been having a some trouble with applying some of the patches uploaded to > JIRA. > > I'd like to suggest and discuss a few guidelines for patches to hopefully > make our lives a little bit easier. BTW, I'm using SVN and Eclipse so I'm > biased towards that as being the lowest common denominator :-) > > - The name of the patch should be WINK-XXX.patch, or WINK-XXX.updateX.patch > for updates of patches > > - The root of the patch should be trunk (or the branch when it will > applicable) whenever possible. If necessary, the root should be under the > trunk (or branch) but avoid creating the patch from the parent of trunk. > > - Avoid using GIT for patches. I'm not sure what it means, but there was this > one patch I saw that had GIT in it, I think it was WINK-28 and I couldn't get > it to work. I even tried to manually edit the file but still couldn't get it > to work. > > What do you think? > > -Nadav > > > -- - Bryant Luk
