I see. In that case, I'd add a new WcaLog that takes the Unicode formatter.
Maybe WcaLogUnicode() or something. Not sure we want to use the A/W convention
since logging everywhere pretty much expects ANSI format strings (to keep
executable size down) and not sure we want to automatically switch logging when
compiled UNICODE or not which the A/W implies.
From: Keith Neuse [mailto:kne...@gmail.com]
Sent: Monday, November 25, 2013 11:56 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] Unicode support for WcaLog
I want WcaLog to work even when it's used in environments where multiple
languages are used. The issue with Wcalog today is that Unicode strings do not
always output correctly even when using the Unicode format parameter "%ls". The
use case is logging cyrillic text while the default code page is set to
Windows-1252. The output is an empty string.
--code snippet--
WcaLog(LOGMSG_STANDARD, "Wide Char parameter %ls", "Это проверка");
WcaLog(LOGMSG_STANDARD, "Wide Char parameter %S", "Это проверка");
WcaLog(LOGMSG_STANDARD, "Wide Char cast to CStringA %s", CStringA("Это
проверка"));
--- output from code snippet ---
: Wide Char parameter
: Wide Char parameter
: Wide Char cast to CStringA ??? ????????
On Nov 25, 2013 11:13 AM, "Rob Mensching"
<r...@robmensching.com<mailto:r...@robmensching.com>> wrote:
What exactly do you want to change? The WcaLog already supports passing
Unicode data to the function, it's just the format string that is ANSI. For
example: WcaLog(LOGMSG_STANDARD, "This is a Unicode string: %ls", wzData);
should work just fine.
We definitely don't want to change WcaLog to force using a Unicode string. That
would just bloat all uses of WcaLog unnecessarily since Unicode strings take
twice as much string as ANSI strings (and we have lots of log strings).
-----Original Message-----
From: Keith Neuse [mailto:kne...@gmail.com<mailto:kne...@gmail.com>]
Sent: Friday, November 22, 2013 10:17 AM
To: wix-devs@lists.sourceforge.net<mailto:wix-devs@lists.sourceforge.net>
Subject: [WiX-devs] Unicode support for WcaLog
I would like to re-write the WcaLog method and methods that depend on WcaLog in
order to support unicode strings. Microsoft has deprecated multi-byte char
support for their MFC library and now requires being built with unicode support
in Visual Studio 2013. If you want to use MFC in custom actions it creates a
lot of head aches to log the strings because now you have to convert unicode
strings to Ansi strings. This will result in loss of data if you write text
outside of the default code page selected in the OS. Every application today
should support unicode strings.
I would like to get the okay before making the changes.
Thanks,
Keith
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription Software experts and developers:
Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net<mailto:WiX-devs@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/wix-devs
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
