Fine by me but I'm not one that would be too upset by it. I think I use the .zip file most everywhere already anyway.
Only question I had on the PR was this means the inc files are shared across sdk MSIs now. Component Rules should be fine since we single-file-component everything... but it does mean we're subjected to them more. _______________________________________________________________ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ -----Original Message----- From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Thursday, July 17, 2014 1:28 PM To: wix-devs@lists.sourceforge.net Subject: [WiX-devs] Bug 4474: The binaries zip file and the full install have different content in the SDK folder I just submitted https://github.com/wixtoolset/wix3/pull/115 to fix bug 4474. In addition to uncontroversially syncing the headers and libraries between the binaries .zip and the native sdk .msi, I relocated the headers to sdk\inc instead of sdk\VS20xx\inc in the installer. I'm fairly comfortable with this change; the mismatch means people had to play around anyway. A nice benefit of this change is that the SDK should now be identical and therefore much easier to diff when stuff like this comes up (i.e., everyone forgetting that the headers have to be added to the setup). C:\Program Files (x86)\WiX Toolset v3.9 ├──bin │ └──x86 ├──doc └──SDK ├──inc ├──VS2012 │ └──lib │ ├──x64 │ └──x86 ├──VS2013 │ └──lib │ ├──x64 │ └──x86 ├──x64 └──x86 Anyone think this is a horrible idea (or especially horrible for RC2)? If not, I'll write a blog post announcing it as a breaking change. -- sig://boB http://joyofsetup.com/ ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
