As far as your workflow/process, I prefer to commit/push early and often on feature branches. Then once I get to the point of thinking my changes are "stable", I'll create a new feature branch that is a squashed commit of all the working commits of the original feature branch. This allows you to save your progress, and to provide a clean history when the pull request is merged into the wixtoolset. (Note, Rob/Bob could do squashed merges but I prefer to make the original pull request as easy as possible for them.)
If you're talking about tests in 4.x, lots of them are broken. Not sure of the 3.x status on the test. -----Original Message----- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Thursday, November 20, 2014 6:13 PM To: wix-devs@lists.sourceforge.net Subject: [WiX-devs] [SPAM] 4592 - RestartResource solution and review Based on helpful input from Jacob and the folks in the meeting today, I adopted Bob's method of building changes by deleting the output 'build' folder and running a build of wix.proj, (because while wixca.dll was being built with changes, WixUtilExtension.dll was not being updated). It takes a little more than the reported 32 seconds (Time Elapsed 00:07:53.98) and gives me more time to ponder my next move if the change fails to do what I want it to. Also in the middle of this research for some reason in VS2013, F9 stopped adding Breakpoints, but right-clicking and selecting Insert Breakpoint still works. The core problem is that when another process is running under a different user account, the process calling OpenProcess must have SeDebugPrivilege. This is true even if PROCESS_QUERY_LIMITED_INFORMATION were used. I resolved the problem by lifting code from serviceconfig.cpp ConfigService() (which added SeShutdownPrivilege), and modified it to add SeDebugPrivilege. Initially I also followed the approach in ConfigService() to removed the SeDebugPrivilege, however after stepping through the problem area successfully and returning to the disassembler, a fault is hit again later and the error reports the fault as the same CA. When I removed the code to reset the privilege this later fault is not observed and the setup succeeds. I have tested this several times with my scenario which includes targeting a tray app launched under NetworkService account. I have not succeeded in building an 'Official' Release build yet, so there are other operating system scenarios to test. I have VS2010, 2012, and 2013 installed, but it fails, so I need to track down the missing SDK or whatever the issue is. Thank you Jacob for the pointers on using git/github. The next steps in that email are: <Add/Commit your changes> <Push your changes to origin (your fork)> <Submit a pull request from github> It looks like the github app has a link that will do the 'commit'. And then they have a 'publish' button. Should I do any of these steps so you folks can review the changes and let me know if I should make additional changes (in parallel with or before) figuring our how to test these changes on other OS/test configurations. Do you see any problem with not removing the SeDebugPrivilege for the remainder of the life of this CA process? Or do you have any insight on how to narrow down what is happening later which apparently also needs SeDebugPrivilege or fails? Also I tried to run test.bat but it reports lots of failures, so I assume that is related to whatever is missing and causes a Release build to fail. Tests:22 Failures 5 RegisterArpMinimumTest, RegisterArpFullTest, etc. Thanks for the help. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/4592-RestartResource-solution-and-review-tp7598149.html Sent from the wix-devs mailing list archive at Nabble.com. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
