On 09-Dec-14 13:12, Phill Hogland wrote: > I submitted a pull request. I am still a little confused on the process so > please let me know what I should do different. Thanks for all of the > assistance! The pull request was fine -- there were no conflicting changes so you didn't have to rebase. I left a few comments, mostly about style. A couple of other things I wanted to bring up here for discussion:
- Taking the debug privilege seems heavy-handed. Do we always want to try to tell RM about processes from other users or should it be opt-in (i.e., an attribute that turns on "try really hard"). - Because MSI reuses custom action hosts, I think that regardless of which privileges are used, we have to restore them to their original set. -- sig://boB http://joyofsetup.com/ ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
