The motivation for this patch series came from Tamas' observation that copyFile() from getstyle.c and fetchFile() from wcolorpanel.c were very similar and his subsequent suggestion that they could perhaps be moved to libWUtil.
So now both files use the same function from libWUtil. And I've made small code cleanups while looking at the code, and there's definitely more that can be done (but it's over for me now). Comments and especially some testing are welcome. [PATCH 1/6] WINGs: Make fetchFile() more similar to copyFile() from getstyle.c [PATCH 2/6] WINGs: Add copy_file() to libWUtil [PATCH 3/6] WINGs: Replace fetchFile() by copy_file() in wcolorpanel.c [PATCH 4/6] getstyle: Use new copy_file() from libWUtil and delete copyFile() [PATCH 5/6] getstyle: Get rid of abortar() [PATCH 6/6] getstyle: Remove dead code WINGs/WINGs/WUtil.h | 2 + WINGs/findfile.c | 57 +++++++++++++++++++++++++++++ WINGs/wcolorpanel.c | 47 +----------------------- util/getstyle.c | 99 +++++--------------------------------------------- 4 files changed, 70 insertions(+), 135 deletions(-) -- To unsubscribe, send mail to [email protected].
