Hi Carlos,

In patch 5/6, I'd guess there's a little mistake for the 'exit', I think it 
should be placed after the "if (ThemePath)" and not inside to keep the original 
behaviour which is probably expected, please see below if not clear.

On a side not, I think you meant "werror" and not "wwarning", as it seems that 
the initial behaviour was to stop, and not to continue anyway (and werror does 
not seem to try to quit by itself).

Regards,
Christophe.


----- Mail d'origine -----
De: Carlos R. Mafra <[email protected]>
À: [email protected]
Envoyé: Sun, 15 Jan 2012 16:08:11 +0100 (CET)
Objet: [PATCH 5/6] getstyle: Get rid of abortar()

Instead of using a temporary buffer to store a "reason" string
which is later printf()'ed by abortar(), use wwarning() directly
and do the small cleanup done by abortar() on the spot.

[...]

        fullPath = wfindfileinarray(PixmapPath, file);
        if (!fullPath) {
-               char buffer[4000];
-
-               sprintf(buffer, "could not find file %s", file);
-               abortar(buffer);
+               wwarning("Could not find file %s", file);
+               if (ThemePath) {
+                       (void)wrmdirhier(ThemePath);
+                       exit(1);     <-- ***Not here***
+               }
***here*** ->   exit(1);
        }
        copy_file(dir, fullPath, fullPath);
        free(fullPath);
--
1.7.3.4


--
To unsubscribe, send mail to [email protected].


--
To unsubscribe, send mail to [email protected].

Reply via email to