On Sun, 15 Jan 2012 at 18:10:16 +0100, [email protected] wrote:
>
> In patch 5/6, I'd guess there's a little mistake for the 'exit', I
> think it should be placed after the "if (ThemePath)" and not inside to
> keep the original behaviour which is probably expected, please see
> below if not clear.
Thanks a lot for the review, and indeed you're right.
I will update the patch. I haven't pushed to the repo yet and will
wait some more.
> On a side not, I think you meant "werror" and not "wwarning", as it
> seems that the initial behaviour was to stop, and not to continue
> anyway (and werror does not seem to try to quit by itself).
Well, not finding the file is not that bad so I think a warning
is ok; but I have no strong feelings. In any case we will exit anyway.
fullPath = wfindfileinarray(PixmapPath, file);
> if (!fullPath) {
> - char buffer[4000];
> -
> - sprintf(buffer, "could not find file %s", file);
> - abortar(buffer);
> + wwarning("Could not find file %s", file);
> + if (ThemePath) {
> + (void)wrmdirhier(ThemePath);
> + exit(1); <-- ***Not here***
> + }
> ***here*** -> exit(1);
> }
> copy_file(dir, fullPath, fullPath);
> free(fullPath);
--
To unsubscribe, send mail to [email protected].
