You may or might not even have the problem, it depends.

It all depends on wherever the image data comes from in from. It could
already be in the correct order it could not be. If Window Maker uses
a library for conversion, perhaps Debian changed it?

However there could be a detection mechanism. Send Window Maker an
icon of a single color (red for example) or a much better sequence
#336699 then determine if byte swapping is even neccessary.

Which distro is your PPC system and which wmaker-crm are you using
along with all of the dependencies it uses.

On 1/17/12, Rodolfo kix Garcia <[email protected]> wrote:
> On 17/01/12 01:22, GhostlyDeath wrote:
>
>> On my PowerPC Debian Squeeze System, the icons are colored
>> incorrectly. This patch removes the swapping of the data on Big Endian
>> systems, thus causing the icons to be colored correctly.
>>
>> Please check the patch on your big endian systems and see if it either
>> fixes or breaks things. It may only be applicable to Debian Squeeze
>> systems possibly.
>>
>> If the attachment does not work, here is the cat of the patch:
>>
>> From f16fc0a89f1bf08b4eac98e3d905a6e13f929cfb Mon Sep 17 00:00:00 2001
>> From: GhostlyDeath <[email protected]>
>> Date: Mon, 16 Jan 2012 19:00:16 -0500
>> Subject: [PATCH] Remove endian swap for icon image data.
>>
>> The data appears to already be in the native endian format.
>> ---
>>  src/wmspec.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/wmspec.c b/src/wmspec.c
>> index 95985db..1b4cf03 100644
>> --- a/src/wmspec.c
>> +++ b/src/wmspec.c
>> @@ -404,7 +404,7 @@ static RImage *makeRImageFromARGBData(unsigned long
>> *data)
>>
>>      for (imgdata = image->data, i = 2; i < size + 2; i++, imgdata += 4) {
>>              pixel = data[i];
>> -#if BYTE_ORDER == BIG_ENDIAN
>> +#if 0//BYTE_ORDER == BIG_ENDIAN
>>              imgdata[2] = (pixel >> 24) & 0xff;      /* A */
>>              imgdata[1] = (pixel >> 16) & 0xff;      /* R */
>>              imgdata[0] = (pixel >> 8) & 0xff;       /* G */
>
>
>
> Hi,
>
> I cannot reproduce the bug in my PowerPC machine :-?
>
> I didn't have the problem with the last wmaker-crm (branch next) and
> after the patch, I continue without the problem.
>
> Can you send more info about this problem. What I am doing wrong?
>
> Thanks!
>
> Best Regards.
>
> kix
>
> PS. I am using my PowerPC using VNC, but... no problems with the icons
>
> --
> ||// //\\// Rodolfo "kix" Garcia
> ||\\// //\\ http://www.kix.es/
>


-- 
Yeah...


-- 
To unsubscribe, send mail to [email protected].

Reply via email to