On 12/05/2013 0:24, Christophe wrote: > From: Christophe CURIS <christophe.cu...@free.fr> > > The functions are now grouped by source file (groups in alphabetic > order) with the traditional separation mark. This makes the file > easier to work with. > --- > src/funcs.h | 53 ++++++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 38 insertions(+), 15 deletions(-) >
Hi Christophe, thanks a lot for your patches. Hard work. Only one comment about this patch. The file funcs.h contains prototypes for multiple files, and funcs.c doesn't exist. IMO, is better move the prototypes to the right header file, and remove funcs.h. Probably we can apply this idea for src/keybind.h Other options (fuzzy): - Files like extend_pixmaps.h and def_pixmaps.h could be merged. - GNUstep.h and WindowMaker.h probably could be checked,... Again, thanks for your work. kix. -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
