On Sun, 12 May 2013 at 13:13:45 +0200, Christophe wrote: > > ----- Rodolfo García Peñas (kix) <k...@kix.es> a écrit : > > > > Only one comment about this patch. The file funcs.h contains prototypes > > for multiple files, and funcs.c doesn't exist. IMO, is better move the > > prototypes to the right header file, and remove funcs.h. > > Hi, Short answer: That's beyond the goal of this patch. This patch does > not conceptually changes the header, it just makes it easier to work > with. > > Long answer: Well, now that's easier to split it ;-) The current > situation for header is not great, there are a few things worse and > working on this patch series pointed it to me. On personal taste, I'm > in favour to not expand unwisely the alreay-to-big number of header. > Specifically, I dislike headers for just one or two definitions; but I > also approve your idea to have things separated, specially when it > tries to lead to overbig header files... > > So basically, before doing anything there, I'll wait to get the project > maintainer's point of view... (Carlos, that's a subtle hint to catch > you into the troll!)
I tend to prefer having separate header files matching their .c files. It is simpler conceptually. I have no strong feelings about it though. You are doing a great job and you can proceed as you think it's best to fix the remaining issues. -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
