On Sun, 19 May 2013, Christophe escribió: > > ----- Rodolfo García Peñas (kix) <k...@kix.es> a écrit : > > Hi > > > > I Am not with my laptop, short answer. > > > > I don't agree because your proposal is include all headers files in > > all source files. We should include only the headers needed. > > That is conceptually a nice looking idea, but experience has taught me that > it does not scale very well. There are 2 cases which cause problems > occasionally: > > - headers dependencies: when you're in the middle of working on a larger > problem, it is generally annoying to have to hunt down which header you are > missing which is causing use of header 'xxx.h' to fail because it needs > something defined in another header (read: it distracts you from your main > problem, thus increase the risk of error). > > - prototype mismatches: for this case, I would invite you to have a look at > commit > http://repo.or.cz/w/wmaker-crm.git/commit/d517d5cac05a6b0ea905ccf23d79efecb6a0c06e > and more specifically the case for the 2nd line in the comment; and as an > exercise I would invite you to review the patches you proposed and tell me if > you notice anything. > > The one-header-includes-them-all solution may not seem as conceptually > impressive, but pragmatically it has the advantage to gather the header > dependency problem in one place, and completely solves 2nd issue by design. Ok,
no problem for me. IMO the compiler will work with a bigger header file, but no problem. The name for the header file? wmaker.h? I don't like too much "WindowMaker.h". Cheers, kix -- ||// //\\// Rodolfo "kix" Garcia ||\\// //\\ http://www.kix.es/ -- To unsubscribe, send mail to wmaker-dev-unsubscr...@lists.windowmaker.org.
