On Sun, 25 May 2014 at 14:22:22 +0200, Josip Deanovic wrote:
>
> 0.9x also brought a blue panel (I believe it's called switchpanel) which
> is optional and whether you use the switchpanel or not, shaded windows
> are not included in the list of windows that are able to get focus
> when cycling using ALT+TAB.
I don't think this is true.
I believe that Amadeusz correctly identified the cause. You said you
have "SwitchPanelImages = None". Try without that to see that your
issue goes away, I believe.
This commit from 2004 (around wmaker-0.91) introduced this behavior:
commit d63a0b4859b292d82b895ee6ff8f882f3e996f36
Author: kojima <kojima>
Date: Wed Oct 27 02:54:32 2004 +0000
added option to disable switchpanel
fixed some bugs
That patch includes this:
@@ -417,7 +419,8 @@ static WMArray *makeWindowListArray(WScreen *scr, WWindow
*curwin, int works
pace
for (wwin= curwin; wwin && wwin != curwin; wwin= wwin->prev) {
if (((!fl && canReceiveFocus(wwin) > 0) || (fl &&
canReceiveFocus(wwin) < 0)) &&
- (!WFLAGP(wwin, skip_window_list) ||
wwin->flags.internal_window)) {
+ (!WFLAGP(wwin, skip_window_list) ||
wwin->flags.internal_window) &&
+ (wwin->flags.mapped || include_unmapped)) {
WMAddToArray(windows, wwin);
}
}
and this:
@@ -446,7 +449,8 @@ WSwitchPanel *wInitSwitchPanel(WScreen *scr, WWindow
*curwin, int workspace)
panel->scr= scr;
- panel->windows= makeWindowListArray(scr, curwin, workspace);
+ panel->windows= makeWindowListArray(scr, curwin, workspace,
+ wPreferences.swtileImage!=0);
count= WMGetArrayItemCount(panel->windows);
which I think explains Amadeusz observation that you need to set
"SwitchPanelImages = None".
Your patch removes the line setting flags.mapped to 0, so the condition
(wwin->flags.mapped || include_unmapped)
becomes true and the window is added to the list. Alternatively, you can
fix the issue by changing the include_unmapped variable.
And it seems to me that your patch chose the wrong solution. I guess
the patch should clean up the logic behind associating include_unmapped
with wPreferences.swtileImage!=0.
--
To unsubscribe, send mail to [email protected].
