On Sun, 2007-05-27 at 17:46 -0400, Kris Maglione wrote: > On Mon, May 28, 2007 at 09:34:07AM +1200, David McNab wrote: > >Ok - have uploaded fresh code: > > - removed the ugly leo sentinels > > - put imports on separate lines > > - separated import blocks > > - removed the one comment line with tabs in it > > - stuck an __all__ inside wmii.py > > I think that he was agreeing with your sentiment rather than deriding > your code.
No worries - it was slack of me to leave in the Leo sentinels - makes for really ugly code. The other tidy-ups can't hurt either. As for PEP8 - much or most of the standard python libs are themselves PEP8 non-compliant. One thing I'd like to see in a future version of python is a syntax error on tabs that aren't part of strings. :) Cheers David
